[buddypress-trac] [BuddyPress] #5148: Make notifications a separate component

buddypress-trac noreply at wordpress.org
Wed Sep 11 14:48:53 UTC 2013

#5148: Make notifications a separate component
 Reporter:  johnjamesjacoby       |       Owner:  johnjamesjacoby
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  2.0
Component:  Notifications         |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-patch needs-ui  |

Comment (by boonebgorges):

 Awesome, r-a-y!

 I'd suggest that, since `get_where_sql()` is protected and thus shouldn't
 really be used externally, we don't need to test it directly; in the same
 way that we don't want others to use it because the implementation might
 change, we'll also be forced to rewrite those tests should we wish to
 reimplement the SQL. I humbly submit that the tests be for the public API
 functions/methods instead.

 Rest of the patch looks really great.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5148#comment:6>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list