[buddypress-trac] [BuddyPress] #5148: Make notifications a separate component

buddypress-trac noreply at wordpress.org
Tue Sep 10 23:50:13 UTC 2013

#5148: Make notifications a separate component
 Reporter:  johnjamesjacoby       |       Owner:  johnjamesjacoby
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  2.0
Component:  Notifications         |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-patch needs-ui  |

Comment (by r-a-y):

 Thanks for the feedback, Boone.  Good catch on marking `get_where_sql()`
 as protected.

 `class.01b.patch` adds unit tests and fixes some minor things in
 `get_where_sql()` method when passing the `secondary_item_id` and `is_new`
 parameters. (Thank you unit tests!)

 For the unit tests, I'm testing the generated SQL statement made by the
 `get_where_sql()` method against the current statements generated in 1.8.

 Let me know what you think.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5148#comment:5>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list