[buddypress-trac] [BuddyPress] #3460: Support custom post types in activity stream

[buddypress-trac]

#3460: Support custom post types in activity stream
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  new
 Priority:  low           |   Milestone:  1.8
Component:  Activity      |     Version:  1.2.8
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+---------------------------

Comment (by boonebgorges):

 Ha, I didn't see that trishasalas had attached a mockup before submitting
 my comment :)

 I disagree with karmatosed that it's "over complicated and a half
 measure". I think it's pared down about as minimal as it can get - at
 least, the first part of it is. I'm not sure I understand what the
 "comments" bit means, though - does toggling that option mean that
 comments on the CPTs will be put into the activity stream? I'm on the
 fence about this. I don't think we should offer per-CPT toggles for posts
 but not for their comments.

 I'm going to push back against karmatosed on not liking the activity
 settings section. It's true that the section is rarely used by users, but
 this setting will also be rarely used by users, and to my mind it makes
 good sense to put this kind of setting there. As for her alternative
 suggestions:

 > If CPT a tab opens for a full fledges admin panel setting

 This is problematic in a couple ways. First, it introduces a large amount
 of bloat. An installation could have a half-dozen or more CPTs provided by
 various plugins. A tab for each, with nothing but a single toggle, seems
 like a waste of space. More importantly, many plugins that register CPTs
 already have their own settings screens, and it seems more confusing for
 us to create another screen than to put it in a list like trishasalas
 suggests.

 > A function flag you can turn on / off in theme post types - bit like
 post types

 Yes, I imagine we will have a code-level way to turn things on or off
 regardless of the UI. What I'm suggesting is that a UI is also necessary
 if we're going to implement the feature.

 > It's safe to assume if you are using a plugin/theme that has a CPT you
 want it on.

 I disagree. There are many plugins that use CPTs for storing utility-style
 data, in which case you definitely don't want it on. We could look at
 something like the 'public' setting for the post type to make some guesses
 about this, I suppose. More importantly, many plugins already support the
 BP activity stream natively. If we turn everything on by default, then
 there will be double posts for those CPTs. So, while it's possible that
 the feature will be missed by some if we default to "off", it's likely
 that we will screw up some sites in a more serious way (either through
 double posts or through irrelevant data posted to the stream) if defaulted
 to on. It's a decision that's going to have to be made independently on
 every BP installation, which is why I think a UI is non-negotiable.

 Actually, the more I talk about it, the more I wonder whether there's
 going to be an elegant way for us to handle this in core at all. But I
 encourage you all to prove me wrong through continuing this helpful
 discussion :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3460#comment:9>
BuddyPress <http://buddypress.org/>
BuddyPress