[buddypress-trac] [BuddyPress] #4639: Add template hierarchy support

buddypress-trac noreply at wordpress.org
Thu Nov 1 07:36:17 UTC 2012


#4639: Add template hierarchy support
-------------------------+------------------------------
 Reporter:  DJPaul       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Theme        |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------------------

Comment (by DJPaul):

 Nice patch, r-a-y. I think I like splitting up the logic for each
 component.

 > if you use one of these templates, it will become the outer template.
 You are changing the overall page template file to a template specifically
 designed for use as a template part. BP-Default would work fine, but BP-
 Legacy/turtleshell's members/single/home.php is intentionally not a full
 page template.
 This approach does not look like it would work for templates included
 within home.php (for example).

 I know your patch was another iteration, but I noticed that the member
 slugs haven't been sanitised for use in a file name; for example, special
 characters, or people trying to feed in relative paths, and so on. I have
 some @todos in my patch around this.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4639#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list