[wp-trac] [WordPress Trac] #58455: The admin menu remains sticky when displaying warning or error messages on the Site Health page.

[WordPress Trac]

#58455: The admin menu remains sticky when displaying warning or error messages on
the Site Health page.
-------------------------------------------------+-------------------------
 Reporter:  dhrumilk                             |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  6.4
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots has-       |     Focuses:  ui, css
  testing-info commit                            |
-------------------------------------------------+-------------------------

Comment (by ironprogrammer):

 == Test Report
 Patch tested: https://github.com/WordPress/wordpress-develop/pull/5168

 **tl;dr:** This patch introduces a regression in how the admin menu
 scrolls for other admin pages when an error is displayed. IMHO this needs
 some more.

 === Expected Results
 Taking a quick step back, I wanted to look at how users might expect to
 see the admin menu **without** a displayed error. I believe that the
 sidebar menu should scroll ''only as far as needed'' to display the start
 and end of the menu items. Here is how this looks in 6.3:

   [[Image(https://cldup.com/_JIqwQFDNa.gif)]]

 And when an error is displayed, the menu should remain visible, where you
 can't "scroll past it":

   [[Image(https://cldup.com/1mkvsRtltf.gif)]]

 This behavior is the baseline considered in this report.

 === Environment
 - Hardware: MacBook Pro Apple M1 Pro
 - OS: macOS 13.6
 - Browser: Safari 16.6
 - Server: nginx/1.25.2
 - PHP: 8.2.11
 - WordPress: 6.4-alpha-56267-src
 - Active Plugins:
  - test-trac-58455 -- an mu-plugin with the following code:
 {{{#!php
 <?php
 add_action( 'init', function() { trigger_error( 'Testing Trac #58455.' );
 } );
 }}}

 === Actual Results
 - ⚠️ On the Site Health screen, the admin menu scrolls similar to existing
 behavior, though the padding around the error message is improved.
 - ❌ When an error is displayed on other pages, the admin menu scrolls
 inconsistently; sometimes fixed, other times absolute. See Figure 2.

 === Supplemental Artifacts
 ''Figure 1: Comparing WordPress `trunk` (patched) with 6.3, the menu
 behaves the same.''
   [[Image(https://cldup.com/WESWgU3Ztq.gif)]]

 ''Figure 2: Showing how Site Health scrolling "issue" now affects other
 pages. E.g. regression to Dashboard admin menu. Menu should not scroll
 away.''
   [[Image(https://cldup.com/HeMxri4YMO.gif)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58455#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform