[wp-trac] [WordPress Trac] #56228: Add main H1 heading in the site-editor page

[WordPress Trac]

#56228: Add main H1 heading in the site-editor page
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  joedolson
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.3
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  testing                                        |  accessibility
-------------------------------------------------+-------------------------

Comment (by alexstine):

 Replying to [comment:26 joedolson]:
 > Heading hierarchy has been updated in
 https://github.com/WordPress/gutenberg/pull/51696.
 >
 > This does not alter the state of the page if JS is disabled or
 unavailable.
 >
 > I think that this should be committed as well, as it does no harm to the
 site editing experience and provides feedback to a user if the site editor
 fails to load for any reason.
 >
 > @alexstine This is being implemented in PHP as an error state handler;
 it's not about navigating the site editor, but about providing context if
 the site editor does not load.

 @joedolson Sorry, I just checked the patch and see the no JS fallback. I
 think for the post editor, the main heading 1 is actually outside of React
 context so it prevents JS events in React from working properly. Just
 wanted to make sure we were not about to make the same mistake twice. PHP
 should provide the fallback only, not the heading under all circumstances.
 My guess is, we did that to have easier access to the $post->post_type.

 Line 313: https://core.svn.wordpress.org/trunk/wp-admin/edit-form-
 blocks.php

 That's not just the fallback, both the heading 1 are defined there. With
 JS and without JS.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56228#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform