[wp-trac] [WordPress Trac] #58433: WP version in Etag header in load-styles.php file

WordPress Trac noreply at wordpress.org
Thu Jun 15 04:06:49 UTC 2023


#58433: WP version in Etag header in load-styles.php file
-------------------------------------------------+-------------------------
 Reporter:  dav4                                 |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info has-screenshots                   |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 In the [https://github.com/WordPress/wordpress-develop/pull/4618 linked
 pull request]:

 * included quotes around etag per @ironprogrammer's comment
 * modified where the quotes were added so they are detected in time for
 the `HTTP_IF_NONE_MATCH` header/304 response.
 * always set the comparison type to weak (again allows for the 304 header
 to be hit)
 * duplicated it all in the load-styles.php file for CSS
 * added a little code to account for `$wp_[ASSET]->registered[ $handle
 ]->ver === false`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58433#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list