[wp-trac] [WordPress Trac] #58433: WP version in Etag header in load-styles.php file

[WordPress Trac]

#58433: WP version in Etag header in load-styles.php file
-------------------------------------------------+-------------------------
 Reporter:  dav4                                 |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info has-screenshots                   |
-------------------------------------------------+-------------------------
Changes (by ironprogrammer):

 * keywords:  has-patch needs-testing => has-patch needs-testing has-
     testing-info has-screenshots


Comment:

 == Test Report - POC

 Patch tested: attachment:58433-poc-2.diff. This only covers `load-
 scripts.php`, as noted in comment:7.

 === Environment
 - Hardware: MacBook Pro Apple M1 Pro
 - OS: macOS 13.4
 - Browser: Safari 16.5, Google Chrome 114.0.5735.106
 - Server: nginx/1.25.0
 - PHP: 7.4.33
 - WordPress: 6.3-alpha-55505-src
 - In `wp-config.php`: `define( 'SCRIPT_DEBUG', false );`

 === Actual Results
 - ✅ The Etag emitted differs between the separate calls to `load-
 scripts.php`.
 - ✅ [Advanced] The Etag changes when a loaded script version changes,
 e.g. for `jquery-core`. (See the ''Inception''-inspired screenshot in
 Figure 1.)

 === Additional Notes
 - Nginx automatically [http://hg.nginx.org/nginx/rev/e491b26fa5a1 sets
 Etags to "weak" for gzipped assets], hence the tag prefix `W/` in the
 screenshot.

 === Supplemental Artifacts
 ''Figure 1: A) `jquery-core` set to version `3.7.0`, B) `3.7.1`, and C)
 back to `3.7.0` (same as A):''
  [[Image(https://cldup.com/YWOLZAc_-F.png, 75%)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58433#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform