[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function

[WordPress Trac]

#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
 Reporter:  oandregal                            |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.2
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  gutenberg-merge has-patch has-unit-  |     Focuses:
  tests has-testing-info                         |  performance
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  dev-feedback gutenberg-merge has-patch has-unit-tests has-
     testing-info => gutenberg-merge has-patch has-unit-tests has-testing-
     info


Comment:

 Replying to [comment:84 flixos90]:
 >At this point, it is safe to say that a static variable cache is faster
 than a non-persistent cache using WP cache API, so we should go with that
 IMO, since we have no timeline on making the cache persistent anyway

 I agree. It's also less code and complexity.

 Replying to [comment:83 flixos90]:
 >Maybe this is happening somewhere in WordPress - maybe it is not. We
 don't know for sure, and as long as we don't know for sure I don't think
 it's worth optimizing for this "bug".

 I agree with the lean approach.

 The "use cache" param is handy for resetting the static variable cache
 between automated tests (ie one of the ways to accomplish it).

 Replying to [comment:83 flixos90]:
 > My concluded suggestion here would be to proceed with the basic static
 variable cache and commit that.

 Sounds good. Thanks Felix. I'll take look at the PR for commit
 consideration.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:86>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform