[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function

WordPress Trac noreply at wordpress.org
Mon Jan 23 16:30:40 UTC 2023


#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
 Reporter:  oandregal                            |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.2
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback gutenberg-merge has-    |     Focuses:
  patch has-unit-tests has-testing-info          |  performance
-------------------------------------------------+-------------------------

Comment (by flixos90):

 Replying to [comment:74 spacedmonkey]:
 > Replying to [comment:73 flixos90]:
 >  Doing so would bring just as little benefit as using the WP cache API
 does here, since it is effectively similar logic.
 >
 > It is different as the cache group is persistent, if opted in. Which is
 different and would ( I believe ) add benefit.

 Right, it may be different since the cache there is persistent. But we
 need to keep in mind, this only matters for sites that use a persistent
 object cache. Tons of sites do not, and for those, the behavior is the
 same as a non-persistent cache.

 We need to measure performance of this approach to make a decision, not
 base it on assumptions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:85>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list