[wp-trac] [WordPress Trac] #41445: post_parent can prevent media from embedding correctly

[WordPress Trac]

#41445: post_parent can prevent media from embedding correctly
-------------------------------------------------+-------------------------
 Reporter:  loboyle                              |       Owner:
                                                 |  adamsilverstein
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Media                                |     Version:  4.9.4
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback needs-unit-tests has-   |     Focuses:  rest-api
  testing-info needs-patch needs-testing         |
-------------------------------------------------+-------------------------

Comment (by joysons):

 It's worth noting that applying patches to WordPress source code can be a
 complex process and should be done with caution. It's important to ensure
 that the patch is compatible with the current version of WordPress and
 that it doesn't introduce any new issues.
 To avoid encountering similar issues in the future, it's a good idea to
 keep WordPress and its components up to date. Regularly updating
 WordPress, themes, and plugins can help prevent security vulnerabilities
 and ensure that the site is running on the latest stable version of the
 software. Additionally, it's important to keep backups of the site in case
 any issues arise during updates or patches. Updating keywords is an
 important part of maintaining an organized codebase. It helps contributors
 to easily identify the status of a PR and decide where they can best focus
 their efforts. In this case, it is great to hear that the PR is working
 and the issue mentioned in the PR discussion has been resolved in another
 ticket. Removing the **"needs-patch"** and **"needs-testing"** keywords in
 this scenario would be appropriate since they are no longer relevant to
 the PR. Removing the "needs-patch" and "needs-testing" keywords is
 entirely appropriate as they are no longer applicable. However, it's
 important to remember that having working code is just one aspect of
 ensuring that the pull request is of high quality and ready for merging.
 Additionally, a review from a core committer is a necessary step before
 merging any changes into the codebase. Core committers are typically
 experienced developers who have a deep understanding of the codebase and
 can provide valuable feedback on the quality of the
 code[https://d-strictednewsone.blogspot.com/ .] They can also ensure that
 the changes adhere to the project's coding standards and do not introduce
 any potential security vulnerabilities. Overall, updating keywords is just
 one small part of maintaining a healthy codebase. While it is great to see
 progress being made on a PR, it is important to remember that there are
 still critical steps that need to be taken before it can be merged.
 Writing unit tests and getting a review from a core committer are both
 important next steps to ensure that the PR is of high quality and does not
 introduce any new issues into the codebase.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41445#comment:70>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform