[wp-trac] [WordPress Trac] #38672: Custom CSS should work with existing Jetpack custom CSS

WordPress Trac noreply at wordpress.org
Wed Nov 23 05:40:30 UTC 2016


#38672: Custom CSS should work with existing Jetpack custom CSS
-------------------------------------------------+-------------------------
 Reporter:  helen                                |       Owner:
     Type:  defect (bug)                         |  georgestephanis
 Priority:  highest omg bbq                      |      Status:  reopened
Component:  Customize                            |   Milestone:  4.7
 Severity:  blocker                              |     Version:
 Keywords:  has-patch has-unit-tests needs-      |  Resolution:
  testing                                        |     Focuses:
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests needs-
     testing


Comment:

 In [attachment:38672.wp_update_custom_css_post.3.diff]
 ([https://github.com/xwp/wordpress-develop/pull/204/files/9dc5be9..8052e63
 see changes]) I've renamed `customize_update_custom_css_post_content_args`
 filter to just `update_custom_css_data` and moved it from
 `\WP_Customize_Custom_CSS_Setting::update()` to
 `wp_update_custom_css_post()`. The filter's arguments are changed to align
 with the arguments for the new `wp_update_custom_css_post()` function.
 This all seems better but it will require some changes to the WIP Jetpack
 PR and other projects that are in the midst of refactor. But better now
 change than forever be something we're not happy with architecturally.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38672#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list