[wp-trac] [WordPress Trac] #34429: Slack embeds look super ugly

[WordPress Trac]

#34429: Slack embeds look super ugly
-----------------------------------+--------------------
 Reporter:  pento                  |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  4.4
Component:  Embeds                 |     Version:  trunk
 Severity:  blocker                |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+--------------------
Changes (by peterwilsoncc):

 * keywords:  needs-patch => has-patch 2nd-opinion


Comment:

 In [attachment:34429.diff], I've wrapped the embed JavaScript in the
 CDATA/HTML comment combination as detailed on
 [https://developer.mozilla.org/en/docs/Writing_JavaScript_for_XHTML MDN's
 Writing JavaScript for XHTML] page:

 {{{
 <!--//--><![CDATA[//><!--
 Embed JavaScript
 //--><!]]>
 }}}

 Slack does not attempt to display the embed, instead it falls back to the
 opengraph data. This makes sense if they're running the page through the
 same regex as `strip_tags`.

 Reduced case tests:
 http://gh.peterwilson.cc/testing/html-l.html (without `data-secret`)
 http://gh.peterwilson.cc/testing/html-s.html (with `data-secret`)

 Tested in Browser stack usign the reduced cases for:
 IE7+ on WinXP+
 Latest Firefoxes on XP+ and last three OSXs

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34429#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform