[wp-trac] [WordPress Trac] #34429: Slack embeds look super ugly

[WordPress Trac]

#34429: Slack embeds look super ugly
------------------------------+--------------------
 Reporter:  pento             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.4
Component:  Embeds            |     Version:  trunk
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------
Changes (by pento):

 * keywords:  has-patch 2nd-opinion => has-patch commit


Comment:

 Replying to [comment:10 swissspidy]:
 > The problem was that Slack uses the content from every element, so if
 you have some JS to remove the `<noscript>` fallback, the content of both
 elements would show. And if you use external JS to remove the
 `<noscript>`, how do you ensure that it only creates a sandboxed
 `<iframe>`?

 This isn't just to fix Slack. This is also for if the embedded site goes
 down, then the embedding site has a local copy of the data that they can
 display. See: https://github.com/swissspidy/oEmbed-API/issues/161

 [attachment:34429.diff] fixes the Slack issue, I'll add a new ticket
 shortly for the text fallback.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34429#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform