[wp-trac] [WordPress Trac] #32445: `is_callable()` should be checked in `do_shortcode_tag()`, not `add_shortcode()`

WordPress Trac noreply at wordpress.org
Sun Jun 14 19:00:41 UTC 2015


#32445: `is_callable()` should be checked in `do_shortcode_tag()`, not
`add_shortcode()`
-------------------------------------+------------------
 Reporter:  wonderboymusic           |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.3
Component:  Shortcodes               |     Version:  2.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+------------------
Changes (by aaroncampbell):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 The patch seems to work, passes all the tests, etc, but I'm a little leery
 of moving all our default shortcodes into default-filters.php. It all
 seems to work for core, but I'm convinced it won't cause issues elsewhere.
 Can we limit this patch to just the is_callable fix?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32445#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list