[theme-reviewers] Managing the Accessibility-Ready tag

[Joe Dolson]

I just went through the review process for
https://themes.trac.wordpress.org/ticket/15869, which seemed to work well.
The workflow was pretty manual - the reviewer contacted me requesting the
accessibility steps, which I then went through during the course of the
review.

It does add a little time to the review process, with two participating
reviewers, but it wasn't unreasonable.

The workflow that Chip describes would be great; and it would definitely be
better to have some kind of automated method of tracking those tickets and
participation, but in the meanwhile, dealing with them manually is fine.

We do need more people than just myself taking on accessibility-ready
reviews, I think -- I know that Esmi can do it, as well, but in the
long-term I'd like more of the theme reviewers to feel confident knowing
what they're looking for, and I'm happy to help anybody interested gain
that comfort level!

Best,
Joe




On Mon, Jan 20, 2014 at 2:43 PM, Chip Bennett <chip at chipbennett.net> wrote:

> We definitely need a built-in workflow fix for the accessibility review.
> Otto: any suggestions?
>
> What might be ideal is:
>
> 1) If a Theme has the "accessibility-ready" tag, the ticket is processed
> as normal: ticket created, added to appropriate queue
> 2) Ticket is assigned/reviewed as per normal
> 3) New workflow state "resolve as "Accessibility Review needed" replaces
> "resolve as Approved"
> 4) Ticket thus resolved goes into Accessibility queue
> 5) Accessibility reviewer assigns/reviews ticket
> 6) Ticket can now use state "resolve as Approved"
> 7) Remaining workflow stays the same
>
> Can we do this?
>
> Chip
>
>
> On Mon, Jan 20, 2014 at 3:38 PM, Joe Dolson <design at joedolson.com> wrote:
>
>> Wow, yeah - it does say that. But I don't think that the work flow
>> supports that as a possibility. That needs to change in the review
>> guidelines, unless somebody knows a way it can actually be facilitated in
>> the work flow.
>>
>> That would only work if admins could actually edit the themes to remove
>> accessibility-ready tag, as far as I can imagine.
>>
>> Any admin have a reason to think that should stay as is? The work flow
>> doesn't exist, so I don't think it's practical. The review needs to be done
>> at a point where the theme author can resubmit with accessibility fixes or
>> without the accessibility-ready tag, I think.
>>
>> Best,
>> Joe
>>
>>
>> On Mon, Jan 20, 2014 at 2:34 PM, Srikanth Koneru <tskk79 at gmail.com>wrote:
>>
>>> http://make.wordpress.org/themes/guidelines/guidelines-accessibility/
>>> says accessibility review will be done after the theme/update is live.
>>>
>>>
>>> On Tue, Jan 21, 2014 at 1:55 AM, Joe Dolson <design at joedolson.com>wrote:
>>>
>>>> Looks like I cited the wrong ticket; regardless, the theme was not
>>>> reviewed for accessibility in that ticket, either.
>>>>
>>>> Best,
>>>> Joe
>>>>
>>>>
>>>> On Mon, Jan 20, 2014 at 2:23 PM, Srikanth Koneru <tskk79 at gmail.com>wrote:
>>>>
>>>>> accessibility tag was added in
>>>>> https://themes.trac.wordpress.org/ticket/15738 and not in
>>>>> https://themes.trac.wordpress.org/ticket/16122
>>>>>
>>>>>
>>>>> On Tue, Jan 21, 2014 at 1:48 AM, Joe Dolson <design at joedolson.com>wrote:
>>>>>
>>>>>> Hi, theme reviewers!
>>>>>>
>>>>>> I was just checking up on the usage of the accessibility-ready tag,
>>>>>> and I observed something I want to bring up. Specifically, that any theme
>>>>>> that comes up for review which either
>>>>>>
>>>>>> - Adds the tag accessibility-ready from a previous version or,
>>>>>> - Is a child theme of a theme with accessibility-ready
>>>>>>
>>>>>> needs to go through an accessibility review process.
>>>>>>
>>>>>> I'm seeing two issues, one illustrated by
>>>>>> https://themes.trac.wordpress.org/ticket/16122, in which a
>>>>>> previously existing theme added the accessibility-ready tag but was
>>>>>> approved on diff, and a second, illustrated in a couple of cases by child
>>>>>> themes or offshoots of Twenty Fourteen, such as
>>>>>> https://themes.trac.wordpress.org/ticket/15736.
>>>>>>
>>>>>> In the first case, adding the accessibility-ready tag means that we
>>>>>> need to verify that the tag is justified. In the second case, we need to
>>>>>> verify that the changes to the theme don't break accessibility issues - any
>>>>>> of these child themes are making significant color scheme changes, so the
>>>>>> color contrast of the palette needs to be re-verified.
>>>>>>
>>>>>> I just want to make sure that people are being conscious of what the
>>>>>> accessibility-ready tag implies for a theme, and that it really needs to
>>>>>> get particular checking.
>>>>>>
>>>>>> Best,
>>>>>> Joe
>>>>>>
>>>>>>
>>>>>> --
>>>>>> ==================
>>>>>> Joseph Dolson
>>>>>> Accessibility consultant & WordPress developer
>>>>>> http://www.joedolson.com
>>>>>> http://profiles.wordpress.org/joedolson
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> ==================
>>>> Joseph Dolson
>>>> Accessibility consultant & WordPress developer
>>>> http://www.joedolson.com
>>>> http://profiles.wordpress.org/joedolson
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> --
>> ==================
>> Joseph Dolson
>> Accessibility consultant & WordPress developer
>> http://www.joedolson.com
>> http://profiles.wordpress.org/joedolson
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
==================
Joseph Dolson
Accessibility consultant & WordPress developer
http://www.joedolson.com
http://profiles.wordpress.org/joedolson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140120/9ac1192c/attachment-0001.html>