<div dir="ltr"><div><div>I just went through the review process for <a href="https://themes.trac.wordpress.org/ticket/15869">https://themes.trac.wordpress.org/ticket/15869</a>, which seemed to work well. The workflow was pretty manual - the reviewer contacted me requesting the accessibility steps, which I then went through during the course of the review.<br>
<br>It does add a little time to the review process, with two participating reviewers, but it wasn't unreasonable. <br><br></div>The workflow that Chip describes would be great; and it would definitely be better to have some kind of automated method of tracking those tickets and participation, but in the meanwhile, dealing with them manually is fine. <br>
<br></div>We do need more people than just myself taking on accessibility-ready reviews, I think -- I know that Esmi can do it, as well, but in the long-term I'd like more of the theme reviewers to feel confident knowing what they're looking for, and I'm happy to help anybody interested gain that comfort level!<br>
<br>Best,<br>Joe<br><div><div><br><br></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 20, 2014 at 2:43 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">We definitely need a built-in workflow fix for the accessibility review. Otto: any suggestions?<div><br>
</div><div>What might be ideal is:</div><div><br></div><div>1) If a Theme has the "accessibility-ready" tag, the ticket is processed as normal: ticket created, added to appropriate queue</div>
<div>2) Ticket is assigned/reviewed as per normal</div><div>3) New workflow state "resolve as "Accessibility Review needed" replaces "resolve as Approved"</div><div>4) Ticket thus resolved goes into Accessibility queue</div>
<div>5) Accessibility reviewer assigns/reviews ticket</div><div>6) Ticket can now use state "resolve as Approved"</div><div>7) Remaining workflow stays the same</div><div><br></div><div>Can we do this?</div><span class="HOEnZb"><font color="#888888"><div>
<br></div><div>Chip</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 20, 2014 at 3:38 PM, Joe Dolson <span dir="ltr"><<a href="mailto:design@joedolson.com" target="_blank">design@joedolson.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Wow, yeah - it does say that. But I don't think that the work flow supports that as a possibility. That needs to change in the review guidelines, unless somebody knows a way it can actually be facilitated in the work flow.<br>
<br></div>That would only work if admins could actually edit the themes to remove accessibility-ready tag, as far as I can imagine.<br><br></div><div>Any admin have a reason to think that should stay as is? The work flow doesn't exist, so I don't think it's practical. The review needs to be done at a point where the theme author can resubmit with accessibility fixes or without the accessibility-ready tag, I think.<br>
</div><div><br></div>Best,<br>Joe<br></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 20, 2014 at 2:34 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><a href="http://make.wordpress.org/themes/guidelines/guidelines-accessibility/" target="_blank">http://make.wordpress.org/themes/guidelines/guidelines-accessibility/</a><br>
</div>says accessibility review will be done after the theme/update is live.<br>
</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jan 21, 2014 at 1:55 AM, Joe Dolson <span dir="ltr"><<a href="mailto:design@joedolson.com" target="_blank">design@joedolson.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looks like I cited the wrong ticket; regardless, the theme was not reviewed for accessibility in that ticket, either. <br>
<br>Best,<br>Joe<br></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 20, 2014 at 2:23 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">accessibility tag was added in <a href="https://themes.trac.wordpress.org/ticket/15738" target="_blank">https://themes.trac.wordpress.org/ticket/15738</a> and not in <a href="https://themes.trac.wordpress.org/ticket/16122" target="_blank">https://themes.trac.wordpress.org/ticket/16122</a><br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Tue, Jan 21, 2014 at 1:48 AM, Joe Dolson <span dir="ltr"><<a href="mailto:design@joedolson.com" target="_blank">design@joedolson.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div><div><div>Hi, theme reviewers!<br><br>I was just checking up on the usage of the accessibility-ready tag, and I observed something I want to bring up. Specifically, that any theme that comes up for review which either<br>
<br></div>- Adds the tag accessibility-ready from a previous version or,<br>- Is a child theme of a theme with accessibility-ready <br><br></div><div>needs to go through an accessibility review process. <br><br>I'm seeing two issues, one illustrated by <a href="https://themes.trac.wordpress.org/ticket/16122" target="_blank">https://themes.trac.wordpress.org/ticket/16122</a>, in which a previously existing theme added the accessibility-ready tag but was approved on diff, and a second, illustrated in a couple of cases by child themes or offshoots of Twenty Fourteen, such as <a href="https://themes.trac.wordpress.org/ticket/15736" target="_blank">https://themes.trac.wordpress.org/ticket/15736</a>.<br>
<br></div><div>In the first case, adding the accessibility-ready tag means that we need to verify that the tag is justified. In the second case, we need to verify that the changes to the theme don't break accessibility issues - any of these child themes are making significant color scheme changes, so the color contrast of the palette needs to be re-verified. <br>
<br></div><div>I just want to make sure that people are being conscious of what the accessibility-ready tag implies for a theme, and that it really needs to get particular checking.<br><br></div><div>Best,<br>Joe<span><font color="#888888"><br>
</font></span></div><span><font color="#888888">
<br></font></span></div><span><font color="#888888"><div><div><div><div><br>-- <br><div dir="ltr">==================<br>Joseph Dolson<br>Accessibility consultant & WordPress developer<br><a href="http://www.joedolson.com" target="_blank">http://www.joedolson.com</a><br>
<a href="http://profiles.wordpress.org/joedolson" target="_blank">http://profiles.wordpress.org/joedolson</a></div>
</div></div></div></div></font></span></div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">==================<br>Joseph Dolson<br>Accessibility consultant & WordPress developer<br><a href="http://www.joedolson.com" target="_blank">http://www.joedolson.com</a><br>
<a href="http://profiles.wordpress.org/joedolson" target="_blank">http://profiles.wordpress.org/joedolson</a></div>
</div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">==================<br>Joseph Dolson<br>Accessibility consultant & WordPress developer<br><a href="http://www.joedolson.com" target="_blank">http://www.joedolson.com</a><br>
<a href="http://profiles.wordpress.org/joedolson" target="_blank">http://profiles.wordpress.org/joedolson</a></div>
</div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">==================<br>Joseph Dolson<br>Accessibility consultant & WordPress developer<br><a href="http://www.joedolson.com" target="_blank">http://www.joedolson.com</a><br>
<a href="http://profiles.wordpress.org/joedolson" target="_blank">http://profiles.wordpress.org/joedolson</a></div>
</div>