[theme-reviewers] Include setting for paginate_comments_links or theme's custom one?
chip at chipbennett.net
Mon Jan 21 23:28:57 UTC 2013
In general, *enhancing* core functionality is fine, while *circumventing*
it is not. So, if the core function can't be modified as needed via
parameters or filters, then one legitimate implementation is to provide a
Theme option for an "enhanced" version of the function.*
I don't think the default value for the option is of any particular
* The best-of-both-worlds action would be to submit the
improvement/enhancement to Trac as a patch to the core
function/functionality. Any time a Theme developer finds a way to build
upon/enhance a core function, I strongly recommend trying to push that
enhancement back upstream to core.
On Mon, Jan 21, 2013 at 6:24 PM, Daniel Fenn <danielx386 at gmail.com> wrote:
> Hi there,
> In the guidelines it says that we are required to use
> paginate_comments_links (and other hooks), is it ok to include our own
> custon one (the paginate_comments_links(); would have been fine but
> the class needs to be changed and some extra html needs to go in) and
> then put a setting in under theme options allowing users to chose what
> they want to use?
> Same with paginate_links(); as well.
> And if the answer is yes, what must be the default setting?
> Daniel Fenn
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers