[Bb-trac] [bbPress] #1080: Template function filters should receive relevant ids

bbPress bb-trac at lists.bbpress.org
Fri May 1 17:57:29 GMT 2009


#1080: Template function filters should receive relevant ids
-----------------------+----------------------------------------------------
 Reporter:  filosofo   |       Owner:                  
     Type:  defect     |      Status:  new             
 Priority:  normal     |   Milestone:  1.0             
Component:  Front-end  |     Version:  1.0-beta (trunk)
 Severity:  normal     |    Keywords:  has-patch       
-----------------------+----------------------------------------------------
 In a number of template function filters, the functions receive arguments
 that include the relevant object's id, but they do not pass on that id to
 the filter.

 This is a problem because:
  * It's inconsistent with how most bbPress filters behave.
  * It forces a filter callback to rely on global variables, which may not
 be correct in the context in which it's being used.
  * In general, a callback should be able to distinguish among as many
 situations as can be specified by the filter's parent function arguments.

 My patch fixes the problem in a backwards-compatible way, by adding the
 appropriate id to the filters.

-- 
Ticket URL: <http://trac.bbpress.org/ticket/1080>
bbPress <http://bbpress.org/>
Innovative forum development


More information about the Bb-trac mailing list