[Bb-trac] [bbPress] #1079: bb_get_post_delete_link() and bb_get_post_undelete_link() should be distinct

bbPress bb-trac at lists.bbpress.org
Fri May 1 17:28:48 GMT 2009


#1079: bb_get_post_delete_link() and bb_get_post_undelete_link() should be
distinct
-----------------------+----------------------------------------------------
 Reporter:  filosofo   |       Owner:                                                                           
     Type:  defect     |      Status:  new                                                                      
 Priority:  normal     |   Milestone:  1.0                                                                      
Component:  Front-end  |     Version:  1.0-beta (trunk)                                                         
 Severity:  normal     |    Keywords:  bb_get_post_delete_link bb_get_post_undelete_link bb_post_admin has-patch
-----------------------+----------------------------------------------------
 If you want customizable, parallel markup, bb_post_admin() and
 bb_get_post_delete_link() are unhelpful, because bb_post_admin()
 concatenates all the edit lines with just a new line, and
 bb_get_post_delete_link() joins the delete and undelete links with just a
 space.

 This is a problem for markup and styling in general, but also for
 accessibility, as accessibility guidelines usually say that there should
 be a markup distinction between links.

 Delete and undelete should have separate functions, and bb_post_admin()
 should make the separation text customizable.  That's what my patch does.

-- 
Ticket URL: <http://trac.bbpress.org/ticket/1079>
bbPress <http://bbpress.org/>
Innovative forum development


More information about the Bb-trac mailing list