[wp-trac] [WordPress Trac] #46976: Twenty Nineteen: remove postcss-focus-within

[WordPress Trac]

#46976: Twenty Nineteen: remove postcss-focus-within
-------------------------------------+------------------------------
 Reporter:  afercia                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Bundled Theme            |     Version:  5.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-test-info  |     Focuses:
-------------------------------------+------------------------------
Changes (by ozgursar):

 * keywords:  needs-testing has-patch => has-patch has-test-info


Comment:

 == Patch Testing Report

 Patch Tested1:
 https://core.trac.wordpress.org/attachment/ticket/46976/46976-for-testing-
 only.patch

 Patch Tested3:
 https://core.trac.wordpress.org/attachment/ticket/46976/46976-3.patch

 === Environment
 - WordPress: 7.0-alpha-61215-src
 - PHP: 8.2.29
 - Server: nginx/1.29.4
 - Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
 - Browser: Chrome 144.0.0.0
 - OS: macOS
 - Theme: Twenty Nineteen 3.2
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.1

 === Steps taken
 1. Install and activate Twenty Nineteen theme
 2. Add menu and submenu items
 3. Check menu items' CSS
 4. Confirm presence of [focus-within] styles (see screenshot - before
 patch)
 5. Apply patch 46976-for-testing-only
 6. Check menu functionality. Menu and submenu works as expected.
 7. Check CSS. Confirm that [focus-within] are replaced with :focus-within
 8. 46976-3.patch
 9. Run `npm install` and `npm run build``
 10. Check menu functionality. Menu and submenu works as expected.
 11. Check CSS. Confirm no presence of `[focus-within]` in the CSS.
 12. ✅ Patch is solving the problem

 === Expected result
 The CSS blocks that uses [focus-within] are removed from style.css

 Example:

 {{{
 main-navigation .main-menu .menu-item-has-children:not(.off-canvas):
 focus-within > .sub-menu {}
 }}}

 === Screenshots/Screencast with results
 Before applying patch:
 [[Image(https://i.imgur.com/I6pUnx2.png)]]

 After applying 46976-for-testing-only.patch:
 [[Image(https://i.imgur.com/J79G0oo.png)]]

 After applying 46976-3.patch
 [[Image(https://i.imgur.com/5WIKwax.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46976#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform