[wp-trac] [WordPress Trac] #64545: Style Engine: Harden add_declaration against being passed illegal values

[WordPress Trac]

#64545: Style Engine: Harden add_declaration against being passed illegal values
-------------------------------------------------+-------------------------
 Reporter:  andrewserong                         |       Owner:
                                                 |  isabel_brison
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  7.0
Component:  Editor                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  gutenberg-merge has-patch has-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by wildworks):

 * keywords:  gutenberg-merge has-patch has-unit-tests dev-feedback =>
     gutenberg-merge has-patch has-unit-tests
 * milestone:  6.9.1 => 7.0


Comment:

 > Where there any changes in 6.9 that would make this easier to encounter?

 AFAIK, there wasn’t any such change in 6.9. Let's change the milestone to
 `7.0`.

 > Also, this is minor but I think the new
 `test_should_reject_non_string_values` test should use a dataProvidor and
 test each of the non string values seperatly so that it's always clear
 which case breaks if the underlying code is changed.

 I'll leave this ticket open to address the feedback above.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64545#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform