[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  reopened
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by dmsnell):

 I’ve merged [61504] which restores the block parser in Core, fixing a
 change that wasn’t necessary in order to make the changes to the build
 system, though while the parser code is back and that should fix a number
 of workflows that were broken by the overall change, the version history
 is messed up now and not directly traversable.

 It’s possible still to see the version history with `git log -- src/wp-
 includes/class-wp-block-parser.php` but going back through the
 blame/annotation on the file leads to a dead-end before the restoration
 commit.

 I’ve never considered rewriting the `trunk` history for a project this
 size, used by so many in so many places, and who knows what would happen
 to so many forks, but it’s really confusing me to sort through the scale
 of this change and the many fixes, which still feel hasty. As some of this
 gets sorted out, I’ve been examining the [https://github.com/dmsnell
 /wordpress-develop/pull/27/files collective whole change] and noting a lot
 of curiosities in the code which raise maintenance concerns.

 I’m particularly weary about all of the ad-hoc `file_exists()` check which
 skirt the issue of removing the PHP files by leaving WordPress in an
 unfunctional state. If we’re copying all of these files from Gutenberg, as
 we have been doing, why not leave them all and overwrite them during the
 build?

 It would be trivial to detect if, after copying, there are updates from
 Gutenberg, and to show those or recreate the commits that changed them.
 This would make Core a mirror of sorts of Gutenberg changes, but would
 bring even more history into Core than we had before.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:115>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform