[wp-trac] [WordPress Trac] #64483: Core Abilities getting error when execution

[WordPress Trac]

#64483: Core Abilities getting error when execution
-------------------------------------------------+-------------------------
 Reporter:  arkenon                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  AI                                   |     Version:  6.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by hbhalodia):

 @justlevine Thanks for the detailed insights and the decisions taken while
 implementing the Abilities API.

 I am also in favor of updating `wp-api-client` to correctly handle and
 pass the intended value to `execute` function, instead of changing in the
 core, but that said I was not 100% sure on whether to fix it to core or
 update the AI client, hence started with a PR. I would be closing the PR
 if we are not intending to fix it on core as per above discussion.

 > The gate therefore intentionally differentiates between an ability
 intentionally called with no value ($a->execute()), but not a
 falsey/potentially malformed one (e.g. $a->execute( 0 ) or $a->execute( [
 ] ).

 I am thinking why we have not added the empty checks? It would have not
 cause the errors, I agree that could be a design decision, but it would
 had been good if at least empty checks were there.

 > Unless the thing feeding [] to it is your orchestrator project.

 I don't think so the orchestrator project is feeding that, because I have
 created a mu-plugin, that uses WP AI Client directly to perform the
 required thing and that still failed, which made me to debug it further.

 > I'll flag the folks working on that plugin first, but assumedly we want
 to close this ticket in favor of one over there

 Looking forward the ticket on https://github.com/WordPress/wp-ai-client to
 fix the issue.

 > If @hbhalodia didn't tag me none of us would have probably seen this
 until it merged

 That would have never happened though, because I would have ultimately
 tagged you on the PR I raised for review 😉.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64483#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform