[wp-trac] [WordPress Trac] #64136: PHP Deprecated: Fetching multiple feeds with single SimplePie instance is deprecated since SimplePie 1.9.0

[WordPress Trac]

#64136: PHP Deprecated:  Fetching multiple feeds with single SimplePie instance is
deprecated since SimplePie 1.9.0
--------------------------------------+-----------------------------
 Reporter:  muryam                    |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  6.9.1
Component:  General                   |     Version:  6.9
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  administration
--------------------------------------+-----------------------------
Changes (by ozgursar):

 * keywords:  needs-testing has-patch has-unit-tests => has-patch has-unit-
     tests


Comment:

 == Test Report
 === Description
 This report validates whether the indicated patch works as expected.

 Patch tested: https://github.com/WordPress/wordpress-develop/pull/10631

 === Environment
 - WordPress: 7.0-alpha-61215-src
 - PHP: 8.2.29
 - Server: nginx/1.29.4
 - Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
 - Browser: Chrome 143.0.0.0
 - OS: macOS
 - Theme: Twenty Twenty-One 2.7
 - MU Plugins: None activated
 - Plugins:
   * LightStart - Maintenance Mode, Coming Soon and Landing Page Builder
 2.6.20
   * Test Reports 1.2.1

 === Steps to Reproduce
 1. Install LightStart-Maintenance Mode plugin from
 https://wordpress.org/plugins/wp-maintenance-mode/
 2. Add the following code snippet to any classic theme's functions.php or
 using Code Snippets plugin to force timeout of "themeisle_sdk_feed_items"
 transient added to trigger fetching the feed each time dashboard home is
 loaded. Thanks to @oglekler for pointing this out.

 {{{
 // Force the timeout to always be in the past (already expired)
 add_filter('option__transient_timeout_themeisle_sdk_feed_items',
 function($value) {
     return time() - 1; // Set to 1 second ago
 });
 }}}

 3. Ensure WP_DEBUG and WP_DEBUG_LOG are enabled in wp-config.php
 4. Visit dashboard home a couple of times to trigger the feed loading
 5. The following log line is added with every pageload

 PHP Deprecated:  Fetching multiple feeds with single SimplePie instance is
 deprecated since SimplePie 1.9.0, create one SimplePie instance per feed
 and use SimplePie::merge_items to get a single list of items. in
 /var/www/src/wp-includes/SimplePie/src/SimplePie.php on line 769

 === Expected Results
 1. ✅ There should not be any PHP depreciation logs

 === Actual Results
 Before applying the patch
 1. Even if transient is not manually forced to expire, PHP Deprecated log
 is added to debug.log once.

 After applying the patch
 1.  ✅ Issue resolved with patch.

 === Supplemental Artifacts
 debug.log before applying patch:

 [[Image(https://files.catbox.moe/feniyr.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64136#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform