[wp-trac] [WordPress Trac] #45955: Twenty Nineteen: get_the_archive_title filter issues

[WordPress Trac]

#45955: Twenty Nineteen: get_the_archive_title filter issues
-----------------------------+------------------------------
 Reporter:  taskotr          |       Owner:  (none)
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Bundled Theme    |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:
-----------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:  has-patch needs-testing => has-patch close


Comment:

 Changing the priority now would cause a problem in any site that uses
 [https://developer.wordpress.org/reference/functions/remove_filter/#description
 remove_filter()] for these hooks at priority 10.
 > To remove a hook, the `$callback` and `$priority` arguments must match
 when the hook was added.

 Using an earlier priority might have been appropriate before the themes
 were publicly available, but changing it after more than five years is not
 good.

 Any filters that adjust the themes' output should already use a priority
 of at least 11, or else the site should remove the default filter at
 priority 10.
 `remove_filter( 'get_the_archive_title',
 'twentynineteen_get_the_archive_title' );`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45955#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform