[wp-trac] [WordPress Trac] #60750: Warning: these pages should not be the same as your Privacy Policy page!

[WordPress Trac]

#60750: Warning: these pages should not be the same as your Privacy Policy page!
-------------------------------------------------+-------------------------
 Reporter:  OctoTooT                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  General                              |     Version:  6.4.3
 Severity:  normal                               |  Resolution:
 Keywords:  needs-screenshots reporter-feedback  |     Focuses:
  has-patch needs-testing                        |
-------------------------------------------------+-------------------------
Changes (by safedawn):

 * keywords:  needs-screenshots reporter-feedback => needs-screenshots
     reporter-feedback has-patch needs-testing


Comment:

 Hello everyone! According to changeset:45766, which introduced this admin
 notice, the intent was to display it only when a Privacy Policy page is
 accidentally set as the Homepage or the Posts page.

 However, when the Homepage, Posts page, or Privacy Policy page is not set,
 their corresponding options in the database are stored as `0`. This leads
 to false positives in the following scenarios:

 * No Privacy Policy page is selected (`wp_page_for_privacy_policy` is
 `0`), and `Your homepage displays` is set to `Your latest posts`
 (`page_on_front` and `page_for_posts` are both `0`).
 * No Privacy Policy page is selected, `Your homepage displays` is set to
 `A static page (select below)`, and one or both of the Homepage and Posts
 page options are not selected.

 The attached patch adjusts the conditional logic to account for unset
 options and prevents the admin notice from being displayed in these cases.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60750#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform