[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  reopened
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by peterwilsoncc):

 1) When doing an update test to `trunk` I noticed that the
 `gutenberg/package.json` file ends up dirty following a build. When
 switching back to the initial hash, this resulted in the following error.

 {{{
 Command errors:
 error: Your local changes to the following files would be overwritten by
 checkout:
         package.json
 Please commit your changes or stash them before you switch branches.
 Aborting

 ❌ Fetch/checkout failed: git checkout FETCH_HEAD failed with code 1
 npm error code 1
 npm error path /Users/peterwilson/Sites/wp-dev/wordpress-develop
 npm error command failed
 npm error command sh -c npm run gutenberg:checkout
 npm error A complete log of this run can be found in:
 /Users/peterwilson/.npm/_logs/2026-01-11T22_25_46_800Z-debug-0.log
 }}}

 This was introduced in r61438 due to the build step changing the package
 file.

 2) When doing the test checkout with `trunk`, I've noticed that the
 `gutenberg-experiments` check introduced in
 [https://github.com/WordPress/gutenberg/commit/3bf3e488fd4bf35bdc7efd8a3571603bd092273d
 Gutenberg at 3bf3e488fd] is included.

 This will mean that if the Gutenberg plugin is disabled without turning
 off the experiment, the experiment will continue to run in WordPress-
 Develop.


 > This is not needed, this a build tool maintained in Gutenberg with the
 same guidelines as Core, it's just another repository. Changes are
 verified there already. Similarly to all the JS, packages and all the
 dependencies.

 I agree, this would be the ideal case but it's not the reality. It's
 common that deprecation errors are caught during the import: either
 functions removed without proper deprecations (as happened on this
 ticket), or missing calls to `_deprecated_*()`.

 Some merge PRs get a few comments, some get dozens of comments.

 The issue I noted above re: the navigation experiment is a case in point.

 > Since this only affects trunk, I don't think there's anything needed
 here unless I'm missing something.

 I thinking about when switching branches as the gutenberg directory will
 be left behind so could be committed in error.

 > I'm having trouble understanding what exactly need to be svn ignored and
 what not. Can we instead just map .gitignore as is in svn:ignore? Happy to
 get some help here as well.

 The map files and package files I am seeing are generated during the build
 step so aren't committed to wp-dev. They'll need to be removed in a change
 to how the build script runs.

 ----

 I am still inclined to revert the commits on this ticket.

 It's a huge change and is causing too much friction for people attempting
 to work on WordPress-Develop.

 Frankly, I think it was irresponsible to commit this in the first palce.
 The PR had had numerous change requests since the initial approval along
 with numerous commits. It was unsuitable for a YOLO commit.

 We're already at four follow up commits and more will need to come.

 @jorbin, @johnbillion, @desrosj as build tools component maintainers, I'd
 value your thoughts.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:66>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform