[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  reopened
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by youknowriad):

 > These auto generated files are also very difficult to review

 The best way to review this is in Gutenberg, we need to review the build
 tool templates. These functions are not just about Core, they are also
 about plugins registering their own pages.

 I've tracked all the enhancement suggestions that you have in
 https://github.com/WordPress/gutenberg/issues/74488

 > I'm seeing a few package.json files, eg wp-
 includes/build/routes/navigation/package.json

 Yes, this is expected, What bothers you with this?

 > I'm seeing a few package.json files, eg wp-
 includes/build/routes/navigation/package.json
 wp_register_development_scripts() has been removed without been deprecated

 Restored and deprecated the function here. https://github.com/WordPress
 /wordpress-develop/pull/10702

 > These changes also make it very unclear what PHP changes are been
 introduced. This is a problem as there are often issues picked up during
 the merge of packages to core. Package bumps will need to provide a diff
 that can be reviewed for the build effects.

 This is not needed, this a build tool maintained in Gutenberg with the
 same guidelines as Core, it's just another repository. Changes are
 verified there already. Similarly to all the JS, packages and all the
 dependencies.

 > We'll also need to consider whether gitignore and SVN props will need to
 be backported to branches receiving security updates to avoid the
 accidental commit of the gutenberg repo in to wp-dev.

 Since this only affects trunk, I don't think there's anything needed here
 unless I'm missing something.

 > The *.map files are still being committed to the build, these will need
 to be removed as they're not referenced in the generated files & the
 references are to uncommitted code.

 I'm having trouble understanding what exactly need to be svn ignored and
 what not. Can we instead just map .gitignore as is in svn:ignore? Happy to
 get some help here as well.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:62>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform