[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  reopened
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:
 Keywords:  needs-patch       |     Focuses:
------------------------------+--------------------------

Comment (by peterwilsoncc):

 I've created a **draft** [https://github.com/WordPress/wordpress-
 develop/pull/10683 pull request] which appears to fix the issue. I am far
 from confident it won't have unintended side effects so haven't marked it
 ready for review.

 In addition to the issue above:
 * I've noticed that the SVN properties were not updated so running `npm
 run build` in the svn repo results in a dirty repo. Very dirty as the
 directory that is been included includes the entire Gutenberg git
 repository.
 * `.map` files have been added to the build repo in
 https://build.trac.wordpress.org/changeset/60750, they're not usually
 included in the distribution.

 Having reviewed the changes further, I am strongly **inclined to revert
 the commits** on this ticket.

 My primary issue is that not enough time was given for people to review
 the pull request. While it was opened on December 16, the majority of
 contributors have been absent from December 19 through to the new year.
 Effectively the PR was only open for three or four business days. Some of
 the busiest business days of the year.

 Secondly, I don't think the changes were tested anywhere near closely
 enough. The Playground link on the originating pull request showed the
 issue but it went unnoticed. Catching this issue was literally two clicks
 away from the PR and it wasn't done.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform