[wp-trac] [WordPress Trac] #17133: Code Editor: Register ctrl + s event for plugin/theme editor

[WordPress Trac]

#17133: Code Editor: Register ctrl + s event for plugin/theme editor
-------------------------------------+-------------------------------------
 Reporter:  jcnetsys                 |       Owner:  westonruter
     Type:  enhancement              |      Status:  accepted
 Priority:  normal                   |   Milestone:  7.0
Component:  Plugins                  |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-ux-feedback has-     |     Focuses:  javascript,
  patch has-test-info                |  administration
-------------------------------------+-------------------------------------
Changes (by huzaifaalmesbah):

 * keywords:  has-ux-feedback has-patch has-test-info needs-testing => has-
     ux-feedback has-patch has-test-info


Comment:

 === Patch Testing Report

 Patch Tested: https://github.com/WordPress/wordpress-develop/pull/10851

 === Environment
 - WordPress: 7.0-alpha-61215-src (trunk)
 - PHP: 8.2.30
 - Server: nginx/1.29.4
 - Database: mysqli (Server: 9.5.0 / Client: mysqlnd 8.2.30)
 - Browser: Chrome 144, Firefox (latest)
 - OS: macOS
 - Theme: Twenty Nineteen 3.2
 - MU Plugins: None
 - Plugins:
   * Classic Editor 1.6.7
   * Test Reports 1.2.1

 === Steps taken
 1. Applied the PR patch.
 2. Ran `npm run build:dev` to rebuild the JavaScript assets.
 3. Opened Appearance → Theme File Editor.
 4. Modified a theme file.
 5. Pressed Cmd/Ctrl + S.
 6. Verified the file saved without triggering the browser “Save Page”
 dialog.
 7. Repeated the same test in Plugins → Plugin File Editor.
 8. ✅ Patch is solving the problem.

 === Expected result
 - Ctrl/Cmd + S should trigger file save.
 - Browser “Save As” dialog should NOT appear.

 === Screenshots/Screencast with results
 Before and after behavior videos:

 Before patch (Ctrl/Cmd + S triggers browser “Save As”):
 https://imgur.com/a/d8zKnVa

 After patch (Ctrl/Cmd + S triggers save without dialog):
 https://imgur.com/a/F7u0Mzc

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/17133#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform