[wp-trac] [WordPress Trac] #18289: Direct link to plugin installation should have admin chrome

[WordPress Trac]

#18289: Direct link to plugin installation should have admin chrome
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-screenshots          |     Focuses:
  changes-requested                              |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing => has-patch needs-screenshots
     changes-requested


Comment:

 Replying to [comment:21 desrosj]:
 > Some pros of this approach:
 > - Uses the same UI.
 > - Allows only specific plugins to be listed (search does not even
 guarantee the intended plugin is listed first).
 > - User can click more details on any of them, and also has an install
 button to click.
 > - Allows plugin and theme authors to link to a specific listing of
 compatible plugins or add-ons.
 >
 > Some cons:
 > - The `plugin_information` action returns way more information than
 needed, and is missing some information for display (plugin icons, for
 example, as seen in the POC patch).
 > - There's no specific API action to just receive a specific set of
 plugins.
 > - Results in one API request per plugin specified. Would be wasteful if
 many (5, 10, 15+ plugins) are listed.
 >
 > This could also be adjusted to only support one plugin. It felt
 reasonable to allow multiple, though.

 I've been testing
 [https://core.trac.wordpress.org/attachment/ticket/18289/18289.7.diff this
 patch] and I found 2 problems commented below. Also, I'm not doing a Test
 Report, because I don't really understand the purpose of all this with a
 single screenshot o design cue.

 1. The first is a ton of errors that I have repaired. Most are because of
 `$plugin` array missing items like `short_description` (L565)

 Full list, for example, for Jetpack

 [[Image(https://i.imgur.com/Kq3P84d.png)]]

 2. No icons in the `$plugin` thing, hence icons appearing empty

 [[Image(https://i.imgur.com/C5cuHy0.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/18289#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform