[wp-trac] [WordPress Trac] #31945: Deleting a user without reassigning should have clearer messaging about the implications

[WordPress Trac]

#31945: Deleting a user without reassigning should have clearer messaging about the
implications
-------------------------------------------------+-------------------------
 Reporter:  jtsternberg                          |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:
Component:  Media                                |     Version:  4.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-refresh 2nd-opinion  |     Focuses:  ui,
                                                 |  administration
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing => has-patch needs-refresh 2nd-opinion


Comment:

 This patch is nice, but it's a little overkill (and it's not applying any
 more, btw, `needs-refresh`). Since there are a couple of post types that
 are not being removed (for example `nav_menu_item`), I wonder if this will
 appear in the `$affected_content` list. Be aware that `nav_menu_items` are
 not removed as part of this "user removal".

 At the present moment, 10 years later, it says: `Delete all content.`. I
 don't think it's that confusing: you are going to delete the content
 generated by this user, which Attachments seem to be an obvious part of
 this.

 But still, instead of going for a complex stunt I would simply choose to
 improve the copy a little, but nothing more because as I say, this has to
 be checking for a lot of post types that will not be necessarily to be
 removed on user deletion, so no need to overcomplicate things. Copy can
 say. "''This includes any kind of posts, pages, comments and media
 files''".

 Would like to hear other opinions (`2nd-opinion`)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/31945#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform