[wp-trac] [WordPress Trac] #63598: Post locking takeover dialogue shows when `show_post_locked_dialog` filter returns false

[WordPress Trac]

#63598: Post locking takeover dialogue shows when `show_post_locked_dialog` filter
returns false
-------------------------------+------------------------------
 Reporter:  paulkevan          |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Posts, Post Types  |     Version:
 Severity:  normal             |  Resolution:
 Keywords:                     |     Focuses:  ui
-------------------------------+------------------------------

Comment (by opurockey):

 When we attempt to avoid the post locking dialogue by setting up
 `show_post_locked_dialog` filter value to false. It will set
 `state.postLock.isLocked` value initially to false. But when the heartbeat
 check returns `wp-refresh-post-lock.lock_error` response, It updates both
 `state.postLock.isTakeover` and `state.postLock.isLocked` and pop up the
 dialogue box. But that box doesn't have any take over button.

 By default takeover dialogue box look like this.

 https://prnt.sc/k0aA7RcH_Ujx

 But if we set `show_post_locked_dialog` filter value false. It looks like
 this

 https://prnt.sc/joVBOIBTZxSu

 You will see there is no takeover button. So far the behavior looks good
 to me but the filter name is confusing I guess. For the classic editor,
 that filter behavior matches exectly as per name but for the GB editor, I
 think we should update the filter name.


 {{{
 File: wp-admin\edit-form-blocks.php - Line - 215
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63598#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform