[wp-trac] [WordPress Trac] #62731: Inline CSS inserted by wp_print_auto_sizes_contain_css_fix too high in HTML
WordPress Trac
noreply at wordpress.org
Sat Jun 14 15:50:02 UTC 2025
#62731: Inline CSS inserted by wp_print_auto_sizes_contain_css_fix too high in HTML
-------------------------------------------------+-------------------------
Reporter: superpoincare | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 6.9
Component: Media | Version: 6.7.1
Severity: minor | Resolution:
Keywords: has-patch has-test-info changes- | Focuses:
requested |
-------------------------------------------------+-------------------------
Comment (by SirLouen):
Replying to [comment:13 westonruter]:
> I [https://github.com/WordPress/wordpress-
develop/pull/8954/commits/41d68bf77e5b2251fd562dfde045459ef9cec8fc
reverted] [https://github.com/WordPress/wordpress-
develop/commit/e7144a3652f8888b1690db58acf361e4d0093912 it] based on
[https://github.com/WordPress/wordpress-
develop/pull/8954#discussion_r2140826261 feedback] from @flixos90.
I'm not 100% convinced, but I understand the points. But I wonder: instead
of being so exaggeratedly specific about what the function is doing, I
wonder why not use a simplified from minute 0 like
`wp_img_auto_sizes_fix`. The print and the enqueue are just a supporting
part of this fact.
It would have saved all this fuzz. I know that flixos is trying to find a
bright side to this deprecation, but all I see is that given the BC
troubles that always WP carry in the backpack, we should learn that the
more specificity, the more risk of these things happening. If this was a
unit test that doesn't have BC risks most of the time, you can do a
function summarizing the function with two dozen words (funny thing
because then most of the functions have no docs, which is paradoxical).
But for core, doing this appears to be problematic.
The original name has been sealed. Ok: now you have a second opportunity
to fix this and simplify the naming.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/62731#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list