[wp-trac] [WordPress Trac] #63268: PHPStan code quality improvements for 6.9

[WordPress Trac]

#63268: PHPStan code quality improvements for 6.9
----------------------------+-------------------------------
 Reporter:  justlevine      |       Owner:  SergeyBiryukov
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  6.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by SergeyBiryukov):

 In [changeset:"60309" 60309]:
 {{{
 #!CommitTicketReference repository="" revision="60309"
 Coding Standards: Remove extra `empty()` in
 `request_filesystem_credentials()`.

 This commit removes an unnecessary `empty( $connection_type )` check, as
 the left side of the same conditional already accounts for a possibly
 empty value.

 Follow-up to [37467].

 Props justlevine.
 See #63268.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63268#comment:111>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform