[wp-trac] [WordPress Trac] #63709: Version 4.6 of twentytwelve theme adds CRLF line endings on every file

[WordPress Trac]

#63709: Version 4.6 of twentytwelve theme adds CRLF line endings on every file
--------------------------+-----------------------------
 Reporter:  pfg           |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Themes        |    Version:
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 We tried to update to version 4.6 of the Twenty Twelve theme today on a
 site where the codebase is versioned in a Git repository. After replacing
 the folder with the latest version of the theme, the diff shows that every
 file in the repository shows that every line has changed, but with no
 visible differences except for the small “actual” changes that were
 introduced in this release.

 Running `git diff | cat -v` as suggested at
 https://stackoverflow.com/a/39502438 seems to indicate that all of the
 line endings in the files have been converted from Unix-style LF to DOS-
 style CRLF

 Here is an example of that diff output for the 404.php file:


 {{{
 diff --git a/wp-content/themes/twentytwelve/404.php b/wp-
 content/themes/twentytwelve/404.php
 index 8b039ecee..2433d6184 100644
 --- a/wp-content/themes/twentytwelve/404.php
 +++ b/wp-content/themes/twentytwelve/404.php
 @@ -1,29 +1,29 @@
 -<?php
 -/**
 - * The template for displaying 404 pages (Not Found)
 - *
 - * @package WordPress
 - * @subpackage Twenty_Twelve
 - * @since Twenty Twelve 1.0
 - */
 -
 -get_header(); ?>
 -
 -       <div id="primary" class="site-content">
 -               <div id="content" role="main">
 -
 -                       <article id="post-0" class="post error404 no-
 results not-found">
 -                               <header class="entry-header">
 -                                       <h1 class="entry-title"><?php _e(
 'This is somewhat embarrassing, isn’t it?', 'twentytwelve' );
 ?></h1>
 -                               </header>
 -
 -                               <div class="entry-content">
 -                                       <p><?php _e( 'It seems we
 can’t find what you’re looking for. Perhaps searching can
 help.', 'twentytwelve' ); ?></p>
 -                                       <?php get_search_form(); ?>
 -                               </div><!-- .entry-content -->
 -                       </article><!-- #post-0 -->
 -
 -               </div><!-- #content -->
 -       </div><!-- #primary -->
 -
 -<?php get_footer(); ?>
 +<?php^M
 +/**^M
 + * The template for displaying 404 pages (Not Found)^M
 + *^M
 + * @package WordPress^M
 + * @subpackage Twenty_Twelve^M
 + * @since Twenty Twelve 1.0^M
 + */^M
 +^M
 +get_header(); ?>^M
 +^M
 +       <div id="primary" class="site-content">^M
 +               <div id="content" role="main">^M
 +^M
 +                       <article id="post-0" class="post error404 no-
 results not-found">^M
 +                               <header class="entry-header">^M
 +                                       <h1 class="entry-title"><?php _e(
 'This is somewhat embarrassing, isn’t it?', 'twentytwelve' );
 ?></h1>^M
 +                               </header>^M
 +^M
 +                               <div class="entry-content">^M
 +                                       <p><?php _e( 'It seems we
 can’t find what you’re looking for. Perhaps searching can
 help.', 'twentytwelve' ); ?></p>^M
 +                                       <?php get_search_form(); ?>^M
 +                               </div><!-- .entry-content -->^M
 +                       </article><!-- #post-0 -->^M
 +^M
 +               </div><!-- #content -->^M
 +       </div><!-- #primary -->^M
 +^M
 +<?php get_footer(); ?>^M
 }}}

 We were able to replicate this by updating the theme both via wp cli theme
 update and by downloading the ZIP from wp.org.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63709>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform