[wp-trac] [WordPress Trac] #61175: Integrate PHPStan into the core development workflow

[WordPress Trac]

#61175: Integrate PHPStan into the core development workflow
--------------------------------------+-------------------------
 Reporter:  westonruter               |       Owner:  justlevine
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  6.9
Component:  General                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-------------------------

Comment (by johnbillion):

 @dmsnell I have also had those same concerns, particularly about coding
 standards which are purely stylistic. I've even given up on PRs to other
 open source projects where the coding standards rules were far too strict
 for my liking.

 I would love for coding standards checks to not cause a PR to fail, but
 we'd still need a way for a committer to ensure nothing gets missed when
 they come to commit the change. It's a bit different with PHPStan though
 because the rules are about correctness, not just opinion. I'd be hesitant
 to implement PHPStan but not require its checks to pass, although I'm open
 to discussing that further.

 It's a shame that GitHub doesn't provide a good developer experience for
 checks that are passing with warnings. A workflow run is either red or
 green and identifying warnings isn't the easiest.

 Automatically fixing PHPCS issues would be the ideal, but AFAIK the
 WordPress Coding Standards have never been fully compatible with PHPCBF. I
 don't know enough about PHPCS to know why that is the case.

 I think this could move to its own ticket as it's not specific to PHPStan.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61175#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform