[wp-trac] [WordPress Trac] #62290: Unable to seek to any bookmark in HTML Processor

[WordPress Trac]

#62290: Unable to seek to any bookmark in HTML Processor
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:  Bernhard
                                                 |  Reiter
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.7.2
Component:  HTML API                             |     Version:  6.6
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests fixed-      |     Focuses:
  major dev-reviewed                             |
-------------------------------------------------+-------------------------
Changes (by jorbin):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"59721" 59721]:
 {{{
 #!CommitTicketReference repository="" revision="59721"
 HTML API: Ensure that full processor can seek to earlier bookmarks.

 When the HTML Processor seeks to an earlier place, it returns the the
 beginning of the document and proceeds forward until it reaches the
 appropriate location. This requires resetting internal state so that the
 processor can correctly proceed from the beginning of the document.

 The seeking reset logic was not adapted to account for the full processor
 (i.e. when created via WP_HTML_Processor::create_full_parser()). This
 change updates the seek logic to account for the full and fragment parsers
 as well as other state that has been introduced in the interim and should
 be reset.

 Reviewed by westonruter, jorbin.
 Merges [59391] to the 6.7 branch.

 Props jonsurrell, dmsnell, westonruter, mi5t4n, bernhard-reiter.
 Fixes #62290.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62290#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform