[wp-trac] [WordPress Trac] #35164: Singular body class and main post post class
WordPress Trac
noreply at wordpress.org
Wed Jan 22 08:21:11 UTC 2025
#35164: Singular body class and main post post class
---------------------------------------------+-----------------------
Reporter: danielpataki | Owner: audrasjb
Type: enhancement | Status: accepted
Priority: normal | Milestone: 6.8
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses:
---------------------------------------------+-----------------------
Changes (by audrasjb):
* keywords: has-patch has-unit-tests => has-patch has-unit-tests commit
* status: reviewing => accepted
Comment:
Hello there,
I tested the PR on both a classic and a block theme.
- It correctly adds `wp-singular` body class to single posts, pages and
custom post types singular posts but doesn't add it to other screens.
- Unit tests updates are looking good to me.
- I found [https://wpdirectory.net/search/01JJ6GKWRQ847WKZ9KWBR60SWT one
occurrence] of `wp-singular` in a plugin, but it is a false positive.
- I found [https://wpdirectory.net/search/01JJ6GV72P8XB2PCY1H31WW7VS 7
occurrences] of `wp-singular` in themes, but all are false positive.
I think we are good to go with the proposed implementation.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35164#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list