[wp-trac] [WordPress Trac] #62822: Playwright Host validation warning when running core performance tests
WordPress Trac
noreply at wordpress.org
Tue Jan 21 02:21:08 UTC 2025
#62822: Playwright Host validation warning when running core performance tests
-----------------------------------+------------------------------
Reporter: johnbillion | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: 2nd-opinion has-patch | Focuses: performance
-----------------------------------+------------------------------
Comment (by euthelup):
I've provided a PR that adds the `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD`
environment to the performance tests, and the warning will disappear.
There is still a catch! Because the performance GitHub action uses an
[https://github.com/WordPress/wordpress-
develop/blob/trunk/.github/workflows/performance.yml#L36 absolute link to
the reusable-perfomance.yml step], the changes in my PR won't have an
effect, and the warning will still be shown.
To demonstrate this change fixes the issue I've created two separate PRs
in my own fork to trigger the performance GitHub action with my own .yml
files.
* This [https://github.com/andreilupu/wordpress-
develop/actions/runs/12878341546/job/35904133818?pr=3 PR workflow] was
triggered with `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true` and the warning is
gone
* This [https://github.com/andreilupu/wordpress-
develop/actions/runs/12878460906/job/35904439626 PR workflow] was
triggered with `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: false` and it does have
the warning
--
Ticket URL: <https://core.trac.wordpress.org/ticket/62822#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list