[wp-trac] [WordPress Trac] #36242: wpdb set_sql_mode add param

[WordPress Trac]

#36242: wpdb set_sql_mode add param
-----------------------------------+------------------------------
 Reporter:  spacedmonkey           |       Owner:  pbearne
     Type:  enhancement            |      Status:  reopened
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Database               |     Version:  3.9
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------
Changes (by spacedmonkey):

 * keywords:  has-patch => has-patch 2nd-opinion
 * status:  closed => reopened
 * resolution:  wontfix =>
 * milestone:   => Awaiting Review


Comment:

 @swissspidy @flixos90 The issue here is that hyperdb and ludicrousdb both
 extend this method to do this. But when this method is called in other
 parts of the class, this parameter is not passed, meaning that LOTS of the
 class has to be override to support overriding this class. Adding this
 parameter making it much easier to override and testing against core
 updates easier too. It also makes the code much more testable.

 CC @johnjamesjacoby for his thoughts as well.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36242#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform