[wp-trac] [WordPress Trac] #62793: Twenty Ten: Link styles breaks the style of the file block

[WordPress Trac]

#62793: Twenty Ten: Link styles breaks the style of the file block
-------------------------------------------------+-------------------------
 Reporter:  poena                                |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-testing-info changes-  |     Focuses:  css
  requested                                      |
-------------------------------------------------+-------------------------

Comment (by sabernhardt):

 The `padding` and `line-height` are appropriate in the File block styles,
 as the PRs add them, but I'll mention other options with a larger scope:
 1. The old [https://github.com/WordPress/wordpress-
 develop/blob/062df4cd8825c3a44de4c05fe612bf3172ede84b/src/wp-
 content/themes/twentyten/style.css#L21-L35 CSS reset] removes any padding
 from standard link elements (`a {padding: 0}`). In theory, the selector
 could be changed to `:where(a)`, and then Core block library styles would
 apply the correct values with `:where(.wp-block-file__button)`. However,
 that is not pretty, and replacing the entire CSS reset could be a better
 choice than editing it with `:where()`.
 2. Replace pixel-based `line-height` values for `body` and `#content`
 rulesets in `style.css` with 1.5. This could be a separate (bigger)
 project on another ticket, but it seems more like an enhancement than a
 bugfix in a very old theme.

 To be clear, adding all three properties in the File block link ruleset
 would be fine, especially because it needs the white text color anyway.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62793#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform