[wp-trac] [WordPress Trac] #58608: Twenty Twenty-One: Text color is not reflected when having background color

[WordPress Trac]

#58608: Twenty Twenty-One: Text color is not reflected when having background color
-------------------------------------------------+-------------------------
 Reporter:  wildworks                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots has-       |     Focuses:  ui, css
  testing-info changes-requested needs-refresh   |
-------------------------------------------------+-------------------------
Changes (by poena):

 * keywords:  has-patch has-screenshots has-testing-info changes-requested
     =>
     has-patch has-screenshots has-testing-info changes-requested needs-
     refresh


Comment:

 I wanted to fully review and test the PR, but I am only able to reproduce
 the reported issue if the striped variation is enabled.

 Theme version: 2.4
 WP: 6.7.1
 Patch tested: https://github.com/WordPress/wordpress-develop/pull/8058

 If the CSS variable {{{var(--table--has-background-text-color);}}} is
 removed, it will be a breaking change for sites where the value of the
 variable has been changed for example by a child theme.
 The default color must not be changed, the original design must be kept
 unless there is no other option.


 The primary color and dark grey only has the same value if the dark mode
 is off and if the body background color has not been changed to a dark
 color.

 But when the body background color is dark enough, the primary color is
 {{{#fff}}}.
 And this color does not have enough color contrast against the **light**
 background on the stripe variation.


 TLDR: The text color that the user selects must work, but the default must
 not be changed.

 When a color is added, the class name {{{has-text-color}}} is added to the
 table.
 This can be used as part of the selector of a new style to set the correct
 text color conditionallty.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58608#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform