[wp-trac] [WordPress Trac] #56455: Twenty Nineteen: Text Color issue in Pullquote Block

[WordPress Trac]

#56455: Twenty Nineteen: Text Color issue in Pullquote Block
-------------------------------------------------+-------------------------
 Reporter:  kajalgohel                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Bundled Theme                        |     Version:  6.0.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-testing-info has-      |     Focuses:  ui, css
  screenshots                                    |
-------------------------------------------------+-------------------------

Comment (by poena):

 There are now 3 tickets open for the same issue, I feel strongly that we
 need to continue working together on one ticket.

 PR 8018 is the most complete patch submitted for the three tickets so far,
 because it updates the files correctly using SASS.


 I want to make the following change requests:

 The default color of the pullquote text and cite must remain the same.
 The original theme design should be kept unless there are no other options
 than to change it.
 Changing the default would be an unexpected change on existing websites,
 and that needs to be weighed in.

 The CSS variable should not be removed from the cite, because there are
 child themes that take advantage of updating the CSS variables with their
 own custom colors.
 If that color was not used anymore it would be a breaking changes, it
 should be avoided unless there are no other options.

 Like @sainathpoojary showed, the theme has a built-in color contrast
 feature that sets an accessible text color when the background color is
 changed to a color from the theme palette. The text color change should
 only happen when the user has **not** selected a text color.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56455#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform