[wp-trac] [WordPress Trac] #59649: PHP 8.0: improvements to allow for named parameters in 6.8

Wed Jan 1 16:15:27 UTC 2025

#59649: PHP 8.0: improvements to allow for named parameters in 6.8
----------------------------+--------------------------------
 Reporter:  hellofromTonya  |       Owner:  (none)
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  6.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  php80           |     Focuses:  php-compatibility
----------------------------+--------------------------------

Comment (by albatross10):

 Task 1

 Subtask: child classes/classes implementing an interface

 1. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/class-wp-block-list.php
         Methods

         `offsetExists()` - Arguments: $offset
         `offsetGet()` - Arguments: $offset
         `offsetSet()` - Arguments: $offset, $value
         `offsetUnset()` - Arguments: $offset
         **Verified and no issues found.**

 2. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/class-wp-feed-cache-transient.php
         Methods

         `__construct( $location, $name, $type )`
         `save( $data )`
         **Verified and no issues found.**

 3. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/class-wp-hook.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 4. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/class-wp-block-list.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 5. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/Requests/src/Hooks.php
         Methods
         `register($hook, $callback, $priority  =  0)`
         `dispatch($hook, $parameters  = [])`
         **Verified and no issues found.**

 6. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/Requests/src/Auth/Basic.php
         Methods
         `register(Hooks  $hooks)`
         **Verified and no issues found.**

 7. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/Requests/src/Cookie/Jar.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 8. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/Requests/src/Proxy/Http.php
         Methods
         `register(Hooks  $hooks)`
         **Verified and no issues found.**

 9. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/Requests/src/Transport/Curl.php
         Methods
         `request($url, $headers = [], $data = [], $options = [])`
         `request_multiple($requests, $options)`
         `test($capabilities  = [])`
         **Verified and no issues found.**

 10. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/Requests/src/Transport/Fsockopen.php
         Methods
         `request($url, $headers = [], $data = [], $options = [])`
         `request_multiple($requests, $options)`
         `test($capabilities  = [])`
         **Verified and no issues found.**

 11. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/Requests/src/Utility/CaseInsensitiveDictionary.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 12. https://github.com/WordPress/wordpress-develop/tree/trunk/src/wp-
 includes/rest-api
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 13. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Item.php
         Methods
         `set_registry(\SimplePie\Registry  $registry)`
         **Verified and no issues found.**

 14. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Locator.php
         Methods
         `set_registry(\SimplePie\Registry  $registry)`
         **Verified and no issues found.**

 15. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Parser.php
         Methods
         `set_registry(\SimplePie\Registry  $registry)`
         **Verified and no issues found.**

 16. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Sanitize.php
         Methods
         `set_registry(\SimplePie\Registry  $registry)`
         **Verified and no issues found.**

 17. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Source.php
         Methods
         `set_registry(\SimplePie\Registry  $registry)`
         **Verified and no issues found.**

 18. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/BaseDataCache.php
         Methods
         `get_data(string  $key, $default  =  null)`
         `set_data(string  $key, array  $value, ?int  $ttl  =  null)`
         `delete_data(string  $key)`
         **Verified and no issues found.**

 19. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/CallableNameFilter.php
         Methods
         `filter(string  $name)`
         **Verified and no issues found.**

 20. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/DB.php
         Methods
         No Methods
         **Verified and no issues found.**

 21. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/File.php
         Methods
         `__construct($location, $name, $type)`
         `save($data)`
         **Verified and no issues found.**

 22. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/Memcache.php
         Methods
         `__construct($location, $name, $type)`
         `save($data)`
         **Verified and no issues found.**

 23. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/Memcached.php
         Methods
         `__construct($location, $name, $type)`
         `save($data)`
         **Verified and no issues found.**

 24. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/Psr16.php
         Methods
         `get_data(string  $key, $default  =  null)`
         `set_data(string  $key, array  $value, ?int  $ttl  =  null)`
         `delete_data(string  $key)`
         **Verified and no issues found.**

 25. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/SimplePie/src/Cache/Redis.php
         Methods
         `__construct($location, $name, $options  =  null)` - There is an
 issue with this one. The [Base](https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-includes/SimplePie/src/Cache/Base.php) Interface
 has `__construct($location, $name, $type)` . Additionally, this might be a
 different task to tackle as the  constructor doc block is also incorrect.
         `save($data)`
         **Verified and found one method with an issue.**

 26. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/sodium_compat/src/Core/ChaCha20/Ctx.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 27. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/sodium_compat/src/Core/Curve25519/Fe.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 28. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/sodium_compat/src/Core32/ChaCha20/Ctx.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 29. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/sodium_compat/src/Core32/Curve25519/Fe.php
         Methods
         `offsetExists( $offset )`
         `offsetGet( $offset )`
         `offsetSet( $offset, $value )`
         `offsetUnset( $offset )`
         **Verified and no issues found.**

 30. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 includes/sodium_compat/src/PHP52/SplFixedArray.php
         Methods
         `offsetExists($index)` - Needs Attention
         `offsetGet($index)` - Needs Attention
         `offsetSet($index, $newval)` - Needs Attention
         `offsetUnset($index)` - Needs Attention
         **Verified and 4 issues found.**

 I will now check the ones that extends and will add more details.

 CC @hellofromTonya

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59649#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform