[wp-trac] [WordPress Trac] #64453: Label of button 'Move to trash' on Settings Panel in Block Editor not changed when constant EMPTY_TRASH_DAYS is defined as false

[WordPress Trac]

#64453: Label of button 'Move to trash' on Settings Panel in Block Editor not
changed when constant EMPTY_TRASH_DAYS is defined as false
---------------------------+------------------------------
 Reporter:  ignatiusjeroe  |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Editor         |     Version:  6.9
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:  ui, javascript
---------------------------+------------------------------

Comment (by hbhalodia):

 Hi @ignatiusjeroe, Thanks for the issue.

 Firstly, EMPTY_TRASH_DAYS as per
 https://codex.wordpress.org/Trash_status#:~:text=(int)%20%3E%3D%200%C2%A0%3A%20the%20length%20of%20days%20before%20items%20are%20permanently%20deleted.%20Default%C2%A0%3A%2030,
 the EMPTY_TRASH_DAYS should be int (>=0) instead of boolean. Though,

 I can verify this indeed an issue, as if we add `0` to the constant, which
 means that no place for trashing, directly delete, the action is performed
 correctly in post editor, but the notifications, labels and even admin
 notice says the item is moved to trash. We need to change it to proper
 labels.

 IMO, this should be raised in upstream GB repository, I will create the
 issue there and will add the link.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64453#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform