[wp-trac] [WordPress Trac] #64453: Label of button 'Move to trash' on Settings Panel in Block Editor not changed when constant EMPTY_TRASH_DAYS is defined as false

[WordPress Trac]

#64453: Label of button 'Move to trash' on Settings Panel in Block Editor not
changed when constant EMPTY_TRASH_DAYS is defined as false
----------------------------+-----------------------------
 Reporter:  ignatiusjeroe   |      Owner:  (none)
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Editor          |    Version:  6.9
 Severity:  normal          |   Keywords:
  Focuses:  ui, javascript  |
----------------------------+-----------------------------
 The ''Move to Trash'' button in the Settings Panel in the Block Editor
 doesnt display the proper text when the  constant 'EMPTY_TRASH_DAYS' is
 defined as false.  This constant, when set to false disables the trash
 function. In the classic editor the button's label is changed from 'Move
 to trash' to 'Delete permanently'. This doesnt happen in the Block Editor.
 The button's label remains 'Move to trash' irrespective of the value of
 'EMPTY_TRASH_DAYS'. The button actually does do its job, but the browser
 confirmation message must be altered, as well as the admin notification
 when redirected to the All Posts page after the button has been pressed.

 Bug instructions:

 - Add following snippet in wp-config.php: define('EMPTY_TRASH_DAYS', false
 );
 - Open post in Block Editor
 - Goto Settings Panel > Post. Find the red button labelled 'Move to
 trash'. It should have been renamed to 'Delete Permanently'.
 - Clicking on it triggers a confirmation window. The message is 'Are you
 sure you want to move "[post title]" to the trash?'. It should be 'Are you
 sure you want to permanently delete "[post title]"?'. The button should
 also be renamed to 'delete permanently'.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64453>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform