[wp-trac] [WordPress Trac] #62061: Prepare for PHP 8.4

WordPress Trac noreply at wordpress.org
Mon Sep 30 21:46:51 UTC 2024


#62061: Prepare for PHP 8.4
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  6.7
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php-84 has-patch has-unit-tests      |     Focuses:  php-
  needs-dev-note                                 |  compatibility
-------------------------------------------------+-------------------------

Comment (by jrf):

 Replying to [comment:52 kkmuffme]:
 > Shouldn't https://core.trac.wordpress.org/changeset/59109 be an
 ErrorException with severity E_USER_ERROR ?

 @kkmuffme Well, considering exceptions weren't really being used in Core
 at all before now (other than in external dependencies), see this as a
 first iteration.

 `WP_Exception` (which is used now) can always be made ''more specific''
 via subclasses without it being a BC-break. Using `ErrorException` can't
 ever be made ''less specific'' without it being a BC-break, so starting
 with extending the plain `Exception` - what with it being the first WP
 native exception being introduced, is baby-steps.

 In a future iteration a good Exception tree for WP should be architected,
 but that's not something to do in this ticket (and definitely not with the
 time pressure to get the PHP 8.4 patches in before WP 6.7-beta1).

 Does that make sense ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62061#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list