[wp-trac] [WordPress Trac] #62118: Code Improvement Suggestion

WordPress Trac noreply at wordpress.org
Thu Sep 26 07:10:14 UTC 2024


#62118: Code Improvement Suggestion
-----------------------------+---------------------------------------------
 Reporter:  ramswarup        |      Owner:  (none)
     Type:  feature request  |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  General          |    Version:  6.6.2
 Severity:  normal           |   Keywords:  needs-testing changes-requested
  Focuses:  coding-          |
  standards                  |
-----------------------------+---------------------------------------------
 Code Improvement Suggestion for admin footer \wp-admin\admin-footer.php
 line No. 35

 $text = sprintf(
         /* translators: %s: https://wordpress.org/ */
         __( 'Thank you for creating with <a href="%s">WordPress</a>.' ),
         __( 'https://wordpress.org/' )
 );



 Should we use esc_url() here instead of __ (underscore) to ensure that the
 URL is valid and protected from cross-site scripting?


 $text = sprintf(
         /* translators: %s: https://wordpress.org/ */
         __('Thank you for creating with <a href="%s">WordPress</a>.'),
         esc_url('https://wordpress.org/')
 );

 Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62118>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list